Skip to content

Added x-source-ui header, logged in http server metrics #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ray-roestenburg-da merged 3 commits into from
Jan 20, 2026
Merged

Added x-source-ui header, logged in http server metrics #3581

ray-roestenburg-da merged 3 commits into from
Jan 20, 2026
+111 −51

Conversation

@ray-roestenburg-da
Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da commented Jan 16, 2026

Fixes #3571

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@ray-roestenburg-da ray-roestenburg-da force-pushed the ray/scan_usage/3571 branch 3 times, most recently from 0c67818 to 1121b31 Compare January 16, 2026 15:57
@ray-roestenburg-da
Copy link
Contributor Author

ray-roestenburg-da commented Jan 16, 2026 •
edited
Loading

imageon scratcha (note the Source UI: scan for the API calls from the UI)

@ray-roestenburg-da ray-roestenburg-da force-pushed the ray/scan_usage/3571 branch 2 times, most recently from f1543fd to 5e2e0bc Compare January 16, 2026 19:37
isegall-da
isegall-da reviewed Jan 16, 2026
View reviewed changes
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/http/HttpServerMetrics.scala
Comment on lines 70 to 72
logger.debug(
s"Request from UI($customSourceUiHeader: $sourceUi): service = $service, operation= $operation"
)
Copy link
Contributor

@isegall-da isegall-da Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, what we want is mostly stats on endpoints that are called not from the UI

Copy link
Contributor Author

@ray-roestenburg-da ray-roestenburg-da Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have those too implicitly but I can add a log for when the header is missing 👍

Copy link
Contributor Author

@ray-roestenburg-da ray-roestenburg-da Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a log debug without source UI header.

@ray-roestenburg-da
Add x-source-ui header to metrics.
2aa9b2f 
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
@ray-roestenburg-da
[ci] handle x-source-ui header (logs metric) from scan UI
1a13102 
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
@ray-roestenburg-da
[ci] add debug log without source UI header
8a7ee9e 
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
@ray-roestenburg-da
Copy link
Contributor Author

ray-roestenburg-da commented Jan 20, 2026

/cluster_test

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Deploy cluster test triggered for Commit 8a7ee9e111c8faf633e1ff3ccb4bffe676036584 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/48112

isegall-da
isegall-da reviewed Jan 20, 2026
View reviewed changes
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/http/HttpServerMetrics.scala
Comment on lines +41 to +42
Operation -> "Descriptor of the HTTP operation done, as per the OpenAPI spec",
Status -> "Status of the HTTP request: completed, rejected, failure",
Copy link
Contributor

@isegall-da isegall-da Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the implications of this change? Do we need to adjust some dashboard?

Copy link
Contributor Author

@ray-roestenburg-da ray-roestenburg-da Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no is just reusing strings

Copy link
Contributor

@isegall-da isegall-da Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, missed that you also dropped the "", I thought you changed the label itself...

isegall-da
isegall-da approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@isegall-da isegall-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@ray-roestenburg-da ray-roestenburg-da merged commit 8cd8373 into main Jan 20, 2026
62 checks passed
@ray-roestenburg-da ray-roestenburg-da deleted the ray/scan_usage/3571 branch January 20, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isegall-da isegall-da isegall-da approved these changes

@moritzkiefer-da moritzkiefer-da Awaiting requested review from moritzkiefer-da

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Scan API usage logs

3 participants

@ray-roestenburg-da @isegall-da